adoroszlai commented on code in PR #8044:
URL: https://github.com/apache/ozone/pull/8044#discussion_r1988333903
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerID.java:
##########
@@ -46,16 +45,20 @@ public static Codec<ContainerID> getCodec() {
}
private final long id;
+ private final HddsProtos.ContainerID proto;
+ private final int hash;
Review Comment:
We can add `@Immutable` on the class. (Only if you update the patch anyway.)
(`import net.jcip.annotations.Immutable;`)
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/container/ReplicationManagerReport.java:
##########
@@ -154,10 +154,6 @@ public Map<String, Long> getStats() {
return result;
}
- /**
- * Return a map of all samples, with the stat as the key and the samples
- * for the stat as a List of Long.
- */
Review Comment:
This change doesn't seem to be related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
