xichen01 commented on code in PR #8008:
URL: https://github.com/apache/ozone/pull/8008#discussion_r1983603405
##########
hadoop-ozone/ozonefs-shaded/pom.xml:
##########
@@ -102,6 +102,15 @@
<phase>package</phase>
<configuration>
<skip>${maven.shade.skip}</skip>
Review Comment:
If a user directly depend on Ozone and use Ozone's Filesystem without
introducing Hadoop's package, can the current Ozone fat-jar provide all
necessary dependencies?
##########
hadoop-ozone/ozonefs-shaded/pom.xml:
##########
@@ -102,6 +102,15 @@
<phase>package</phase>
<configuration>
<skip>${maven.shade.skip}</skip>
Review Comment:
@adoroszlai @ChenSammi
I have an idea
https://github.com/apache/hadoop/blob/d552bb056c3daec8d540f166c41b463e8ef18645/hadoop-client-modules/hadoop-client-api/pom.xml#L131
For these classes that are not shaded in hadoop, should we choose to have
Ozone not include these "hadoop client unshaded classes" because this may cause
class conflicts? (exclude them in `artifactSet` and `relocation`)
We should have two options for Ozone dependencies
1. Shade dependencies
2. Do not shade dependencies, and do not include this dependency in the
ozone release package
In this way, the ozone release package will only contain shaded
dependencies, and for these unshaded dependencies, Ozone will assume that
Hadoop env provides these dependencies.
How do you think ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
