xichen01 commented on code in PR #8008:
URL: https://github.com/apache/ozone/pull/8008#discussion_r1981767767
##########
hadoop-ozone/ozonefs-shaded/pom.xml:
##########
@@ -120,38 +135,48 @@
<relocation>
<pattern>org</pattern>
<shadedPattern>${shaded.prefix}.org</shadedPattern>
- <includes>
- <include>org.yaml.**.*</include>
- <include>org.sqlite.**.*</include>
- <include>org.tukaani.**.*</include>
- <include>org.bouncycastle.**.*</include>
- <include>org.rocksdb.**.*</include>
- <include>org.apache.commons.cli.**.*</include>
- <include>org.apache.commons.compress.**.*</include>
- <include>org.apache.commons.codec.**.*</include>
- <include>org.apache.commons.beanutils.**.*</include>
- <include>org.apache.commons.collections.**.*</include>
- <include>org.apache.commons.digester.**.*</include>
- <include>org.apache.commons.io.**.*</include>
- <include>org.apache.commons.logging.**.*</include>
- <include>org.apache.commons.validator.**.*</include>
- <include>org.apache.commons.lang3.**.*</include>
- <include>org.sqlite.**.*</include>
- <include>org.apache.thrift.**.*</include>
- </includes>
+ <excludes>
+ <exclude>org.apache.commons.logging.**</exclude>
+ <exclude>org.apache.hadoop.**</exclude>
+ <exclude>org.apache.log4j.**</exclude>
+ <exclude>org.apache.ozone.**</exclude>
+ <exclude>org.apache.ratis.**</exclude>
+ <exclude>org.bouncycastle.**</exclude>
+ <exclude>org.hadoop.ozone.**</exclude>
Review Comment:
this one:
https://github.com/apache/ozone/blob/dd74eee7fccd941c7baced88ce75967ef9f269c9/hadoop-hdds/framework/src/main/java/org/apache/ratis/metrics/dropwizard3/RatisMetricsUtils.java#L18
and these is a `com.google.protobuf`
https://github.com/apache/ozone/blob/dd74eee7fccd941c7baced88ce75967ef9f269c9/hadoop-hdds/common/src/main/java/com/google/protobuf/Proto2Utils.java#L18
All the others class package name are `org.apache.hadoop` or
`org.apache.ozone`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
