errose28 commented on code in PR #7786: URL: https://github.com/apache/ozone/pull/7786#discussion_r1971859810
########## hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/metrics/ContainerHealthMetrics.java: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.recon.metrics; + +import org.apache.hadoop.hdds.annotation.InterfaceAudience; +import org.apache.hadoop.metrics2.MetricsSystem; +import org.apache.hadoop.metrics2.annotation.Metric; +import org.apache.hadoop.metrics2.annotation.Metrics; +import org.apache.hadoop.metrics2.lib.DefaultMetricsSystem; +import org.apache.hadoop.metrics2.lib.MutableGaugeLong; +import org.apache.hadoop.ozone.OzoneConsts; + +/** + * Class for tracking metrics related to container health task in Recon. + */ [email protected] +@Metrics(about = "Recon ContainerHealthTask Metrics", context = OzoneConsts.OZONE) +public final class ContainerHealthMetrics { + + private static final String SOURCE_NAME = + ContainerHealthMetrics.class.getSimpleName(); + + private ContainerHealthMetrics() { + } + + public static ContainerHealthMetrics create() { + MetricsSystem ms = DefaultMetricsSystem.instance(); + return ms.register(SOURCE_NAME, + "Recon Container Health Task Metrics", + new ContainerHealthMetrics()); + } + + public void unRegister() { + MetricsSystem ms = DefaultMetricsSystem.instance(); + ms.unregisterSource(SOURCE_NAME); + } + + @Metric(about = "Number of missing containers detected in Recon.") + private MutableGaugeLong missingContainerCount; + + @Metric(about = "Number of under replicated containers detected in Recon.") + private MutableGaugeLong underReplicatedContainerCount; + + @Metric(about = "Number of corrupted containers detected in Recon.") + private MutableGaugeLong corruptedContainerCount; + + public void setMissingContainerCount(long missingContainerCount) { + this.missingContainerCount.set(missingContainerCount); + } + + public void setUnderReplicatedContainerCount(long underReplicatedContainerCount) { + this.underReplicatedContainerCount.set(underReplicatedContainerCount); + } + + public void setCorruptedContainerCount(long corruptedContainerCount) { + this.corruptedContainerCount.set(corruptedContainerCount); Review Comment: We should use the term mismatch, not corruption, to handle mismatched replicas. Containers may have different checksums without having any corrupted data. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
