devabhishekpal commented on PR #7786: URL: https://github.com/apache/ozone/pull/7786#issuecomment-2680692742
Hi @devmadhuu thanks for the patch. Overall it LGTM, but we are missing few tests for the metrics. I think the following test cases would be good to have: - Metrics get incremented on encountering MISSING and UNDER-REPLICATED containers - Resetting the metrics is working properly - Metrics are not affected on encountering other container states It would be great to have a separate class for testing the metrics. [TestS3GatewayMetrics](https://github.com/apache/ozone/blob/master/hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/metrics/TestS3GatewayMetrics.java) has extensive coverage on the respective metrics and it would be good to have better coverage, even if not as extensive - for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
