ivanzlenko commented on code in PR #7827:
URL: https://github.com/apache/ozone/pull/7827#discussion_r1958036970
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneClusterImpl.java:
##########
@@ -118,7 +118,7 @@
@InterfaceAudience.Private
public class MiniOzoneClusterImpl implements MiniOzoneCluster {
- private static final Logger LOG =
+ public static final Logger LOG =
Review Comment:
I think it is better to operate with LoggerFactory.getLogger instead of
making static field public.
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestSecureOzoneRpcClient.java:
##########
@@ -102,7 +102,7 @@ class TestSecureOzoneRpcClient extends OzoneRpcClientTests {
@TempDir
private static File testDir;
- private static String keyProviderUri = "kms://http@kms:9600/kms";
+ private static String keyProviderUri = "kms://http@localhost:9600/kms";
Review Comment:
Let's make it final as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
