adoroszlai opened a new pull request, #7827:
URL: https://github.com/apache/ozone/pull/7827
## What changes were proposed in this pull request?
`TestSecureOzoneRpcClient` test cases are not run:
```
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
11.124 s - in org.apache.hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
```
because cluster startup fails with:
```
UnknownHostException: kms
at
org.apache.hadoop.security.SecurityUtil.buildTokenService(SecurityUtil.java:479)
at
org.apache.hadoop.security.SecurityUtil.buildTokenService(SecurityUtil.java:496)
at
org.apache.hadoop.crypto.key.kms.KMSClientProvider.<init>(KMSClientProvider.java:387)
at
org.apache.hadoop.crypto.key.kms.KMSClientProvider$Factory.createProviders(KMSClientProvider.java:320)
at
org.apache.hadoop.crypto.key.kms.KMSClientProvider$Factory.createProvider(KMSClientProvider.java:305)
at
org.apache.hadoop.crypto.key.KeyProviderFactory.get(KeyProviderFactory.java:96)
at
org.apache.hadoop.util.KMSUtil.createKeyProviderFromUri(KMSUtil.java:83)
at org.apache.hadoop.util.KMSUtil.createKeyProvider(KMSUtil.java:63)
at
org.apache.hadoop.ozone.om.OzoneManager.createKeyProviderExt(OzoneManager.java:988)
at org.apache.hadoop.ozone.om.OzoneManager.<init>(OzoneManager.java:650)
at
org.apache.hadoop.ozone.om.OzoneManager.createOm(OzoneManager.java:787)
at
org.apache.hadoop.ozone.MiniOzoneClusterImpl$Builder.createOM(MiniOzoneClusterImpl.java:790)
at
org.apache.hadoop.ozone.MiniOzoneClusterImpl$Builder.createAndStartSingleOM(MiniOzoneClusterImpl.java:774)
at
org.apache.hadoop.ozone.MiniOzoneClusterImpl$Builder.build(MiniOzoneClusterImpl.java:637)
at
org.apache.hadoop.ozone.client.rpc.OzoneRpcClientTests.startCluster(OzoneRpcClientTests.java:257)
at
org.apache.hadoop.ozone.client.rpc.TestSecureOzoneRpcClient.init(TestSecureOzoneRpcClient.java:133)
```
Unfortunately errors in `@BeforeAll` do not trigger test failure. This is
fixed in [SUREFIRE-1688](https://issues.apache.org/jira/browse/SUREFIRE-1688),
but we use an older version (see HDDS-10552 for the reason).
Changes in this PR:
1. Fail _integration_ check if `MiniOzoneCluster` cannot be started.
2. Disable `MiniOzoneCluster` logging in test cases where startup failure is
expected (otherwise test log post-processing would fail the check)
3. Fix `TestSecureOzoneRpcClient` cluster startup failure (the
`UnknownHostException`)
4. Fix leak of `FileSystem` in `TestSecureOzoneRpcClient` (which went
unnoticed since the test was not being run)
https://issues.apache.org/jira/browse/HDDS-12226
## How was this patch tested?
Verified that _integration_ check fails without the fix in
`TestSecureOzoneRpcClient`:
```
$ ./hadoop-ozone/dev-support/checks/integration.sh
-Dtest='TestSecureOzoneRpcClient'
...
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.205
s - in org.apache.hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
...
[INFO] BUILD SUCCESS
...
$ echo $?
1
$ cat target/integration/summary.txt
org.apache.hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
$ cat target/integration/summary.md
# Cluster Startup Errors
* org.apache.hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
```
CI:
https://github.com/adoroszlai/ozone/actions/runs/13178821363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
