adoroszlai commented on PR #38: URL: https://github.com/apache/ozone-docker/pull/38#issuecomment-2583644485
> Side note, we need to move ozone-latest to point to ozone-1.4.1. That step may not be present in the release guide. https://issues.apache.org/jira/browse/HDDS-12046?focusedCommentId=17911354&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17911354 > To override configs in the image, mount a config file as a volume on top of the existing config file in the image. This will effectively replace it. Injecting config via the environment variables makes it easy to add or replace _some_ properties. XML files cannot be composed this way: replace `ozone-site.xml` as a whole. One more config file can be added with the `-conf` option. We may improve it by allowing multiple `-conf` options (or preferably `--config-file`...). > passing -D<key>=<value> to the service's entrypoint The `-D` settings defined for entrypoints are not applied to any command run with `docker compose exec` in the same container. > The whole env variable + python script thing always looked strange to me. Using it only for Ozone is probably overkill in a way. Marton designed it as a uniform way to define configs for images of various services in the ecosystem (Hadoop, Spark, Kafka, etc.). I think fundamentally changing the way configuration is defined is out of scope in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
