adoroszlai commented on PR #38:
URL: https://github.com/apache/ozone-docker/pull/38#issuecomment-2581853886

   > * Do we need a different set of configs for docker compose vs the 
`ozone-site.xml` already included in the image?
   
   `ozone-site.xml` in the image is a placeholder, which comes from the Ozone 
release tarball.  The image used to overwrite the placeholder, but it was 
removed in b9fe9d22cecfd509e20b6909bd9ab4b43735ca7c.
   
   ```
   $ docker run -it --rm 
ghcr.io/apache/ozone:b38e5431f535d7a56752c0eb7e58031d2b6a4e4a bash -c 'cat 
$OZONE_CONF_DIR/ozone-site.xml'
   <?xml version="1.0"?>
   <?xml-stylesheet type="text/xsl" href="configuration.xsl"?>
   <!--
      Licensed to the Apache Software Foundation (ASF) under one or more
      contributor license agreements.  See the NOTICE file distributed with
      this work for additional information regarding copyright ownership.
      The ASF licenses this file to You under the Apache License, Version 2.0
      (the "License"); you may not use this file except in compliance with
      the License.  You may obtain a copy of the License at
   
          http://www.apache.org/licenses/LICENSE-2.0
   
      Unless required by applicable law or agreed to in writing, software
      distributed under the License is distributed on an "AS IS" BASIS,
      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
      See the License for the specific language governing permissions and
      limitations under the License.
   -->
   
   <!-- Put site-specific property overrides in this file. -->
   
   <configuration>
   
   </configuration>
   ```
   
   > * Is `envtoconf.py` being invoked somewhere to act on the variables? Can 
we test that it is not actually using the `ozone-site.xml` that is already 
included in the image?
   
   `envtoconf.py` is invoked by `/opt/hadoop/libexec/entrypoint.sh`, the 
entrypoint of the (parent) image.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to