[
https://issues.apache.org/jira/browse/NIFI-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121741#comment-16121741
]
ASF GitHub Bot commented on NIFI-4224:
--------------------------------------
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2051#discussion_r132472005
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java
---
@@ -314,7 +430,7 @@ public Response updateProcessGroup(
Authorizable authorizable =
lookup.getProcessGroup(id).getAuthorizable();
authorizable.authorize(authorizer,
RequestAction.WRITE, NiFiUserUtils.getNiFiUser());
},
- null,
+ () ->
serviceFacade.verifyUpdateProcessGroup(requestProcessGroupDTO),
--- End diff --
Good call. Originally, I had it updating the variables here but then
refactored quite a bit. I think it's best to go ahead and leave in the addition
of the verifyUpdateProcessGroup method, but make the verification a NOP. We do
this in a few other places, as well, so I feel it's best to leave the
'plumbing' there, since it's already been built. It will make it easier to
update later.
> Add Variable Registry at Process Group level
> --------------------------------------------
>
> Key: NIFI-4224
> URL: https://issues.apache.org/jira/browse/NIFI-4224
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Core Framework
> Reporter: Mark Payne
> Assignee: Mark Payne
>
> Currently, NiFi exposes a variable registry that is configurable by adding
> the name of a properties file to nifi.properties and then treating the
> referenced properties file as key/value pairs for the variable registry.
> This, however, is very limiting, as it provides a global scope for all
> variables, and it requires a restart of NiFi in order to pick up any updates
> to the file. We should expose a Process Group-level Variable Registry.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
