lordgamez commented on code in PR #2266:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2266#discussion_r4629785066
##########
extensions/opc/src/BaseOPCProcessor.cpp:
##########
@@ -92,37 +93,40 @@ bool BaseOPCProcessor::reconnect() {
return false;
}
logger_->log_debug("Successfully connected.");
+
+ // A new or re-established connection may be to a restarted server that can
reassign node ids,
+ // so if path is used to identify node id, the cached node id should be
invalidated
+ path_node_id_resolved_ = false;
Review Comment:
The flag is used because it not only marks if `node_` is supposed to be
resolved, but also if `translated_node_ids_` should be resolved in
`FetchOPCProcessor` as multiple results are allowed there, but the reconnect is
done in the base class so the flag can only be set there. This is probably not
a good idea, so I'll move have a separate optional member as suggested but with
multiple values allowed in the base class and use that for Path type node id
resolve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]