adamdebreceni commented on code in PR #2266:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2266#discussion_r4610131003
##########
extensions/opc/include/BaseOPCProcessor.h:
##########
@@ -58,19 +58,14 @@ class BaseOPCProcessor : public core::ProcessorImpl {
EXTENSIONAPI static constexpr auto TrustedPath =
core::PropertyDefinitionBuilder<>::createProperty("Trusted server certificate
path")
.withDescription("Comma separated list of paths to the DER-encoded
trusted server certificates")
.build();
- EXTENSIONAPI static constexpr auto PathReferenceTypes =
core::PropertyDefinitionBuilder<>::createProperty("Path reference types")
- .withDescription("Specify the reference types between nodes in the path
if Path Node ID type is used. If not provided, all reference types are assumed
to be Organizes. "
- "The format is
'referenceType1/referenceType2/.../referenceTypeN' and the supported reference
types are Organizes, HasComponent, HasProperty, and HasSubtype.")
- .build();
Review Comment:
why was this property moved to derived classes but related utils remained?
(path_reference_types_, readPathReferenceTypes, parseNode)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]