szaszm commented on code in PR #2155:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2155#discussion_r3060144534
##########
extensions/sql/CMakeLists.txt:
##########
@@ -53,7 +53,7 @@ else()
CMAKE_COMMAND ""
UPDATE_COMMAND ""
INSTALL_COMMAND make install
- CONFIGURE_COMMAND ./autogen.sh && ./configure
--prefix=${IODBC_BYPRODUCT_DIR} --with-pic
+ CONFIGURE_COMMAND ./autogen.sh && ./configure
--prefix=${IODBC_BYPRODUCT_DIR} --with-pic CFLAGS=-std=gnu17
Review Comment:
I would append to the CFLAGS instead of replacing it. Plus I'm not sure why
this applies from the end of the command, normally per command envvar overrides
go before the command, or you use a shell-wide override with export in a
separate command
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
