martinzink commented on code in PR #2155:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2155#discussion_r3056728450
##########
libminifi/test/unit/ExpectedTest.cpp:
##########
Review Comment:
yeah i rather do that in a followup PR, it might have been a bad idea to
purge expected lite in the firstplace with these compiler chagnes
##########
extensions/standard-processors/processors/InvokeHTTP.cpp:
##########
@@ -79,16 +79,16 @@ void HttpClientStore::returnClient(http::HTTPClient&
client) {
} // namespace invoke_http
namespace {
-nonstd::expected<std::string_view, std::error_code> removePerSecSuffix(const
std::string_view input) {
+std::expected<std::string_view, std::error_code> removePerSecSuffix(const
std::string_view input) {
const auto trimmed_input = utils::string::trim(input);
if (trimmed_input.ends_with("/s") || trimmed_input.ends_with("/S")) {
return trimmed_input.substr(0, trimmed_input.size() - 2);
}
- return nonstd::make_unexpected(core::ParsingErrorCode::GeneralParsingError);
+ return std::unexpected(core::ParsingErrorCode::GeneralParsingError);
}
} // namespace
-nonstd::expected<uint64_t, std::error_code>
invoke_http::parseDataTransferSpeed(const std::string_view input) {
+std::expected<uint64_t, std::error_code>
invoke_http::parseDataTransferSpeed(const std::string_view input) {
Review Comment:
good point however those rewrites can be not straightforward, so not gonna
pollute this PR with it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
