lordgamez commented on code in PR #2045:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2045#discussion_r2523743740
##########
CONTROLLERS.md:
##########
@@ -244,6 +245,24 @@ In the list below, the names of required properties appear
in bold. Any other pr
| **File** | | | Path to a
file to store state
|
+## ProxyConfigurationService
+
+### Description
+
+Provides a set of configurations for different MiNiFi C++ components to use a
proxy server.
Review Comment:
Good point, we only support HTTP proxy at the moment. The controller is
based on the NiFi counterpart
https://nifi.apache.org/components/org.apache.nifi.proxy.StandardProxyConfigurationService/
where the proxy type can be specified if there are additional options. We can
add that in the future if we want to support more protocols. Currently the
cloud providers usually support only HTTP proxies, the newer AWS SDK should
support HTTPS as well. Added additional info to the description in
https://github.com/apache/nifi-minifi-cpp/pull/2045/commits/2b46713093565c2e54d6e0bbea6ec8723679096c
##########
minifi-api/include/minifi-cpp/controllers/ProxyConfigurationServiceInterface.h:
##########
@@ -0,0 +1,42 @@
+/**
+* Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#pragma once
+
+#include "minifi-cpp/core/controller/ControllerService.h"
+#include "minifi-cpp/core/ControllerServiceApiDefinition.h"
+
+namespace org::apache::nifi::minifi::controllers {
+
+struct ProxyConfiguration {
+ std::string proxy_host;
+ std::optional<uint16_t> proxy_port;
+ std::optional<std::string> proxy_user;
+ std::optional<std::string> proxy_password;
+};
Review Comment:
As we only support HTTP proxies for now only these parameters are used, they
can be extended or refactored to different methods when other protocols are
introduced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
