Copilot commented on code in PR #2045: URL: https://github.com/apache/nifi-minifi-cpp/pull/2045#discussion_r2416720950
##########
PROCESSORS.md:
##########
@@ -638,7 +640,6 @@ In the list below, the names of required properties appear
in bold. Any other pr
| Name | Default Value | Allowable Values
| Description
|
|----------------------------------|---------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
-------------------------------------------------------|
-| **Bucket** | |
| The S3 bucket<br/>**Supports Expression
Language: true**
|
| Access Key | |
| AWS account access key<br/>**Supports
Expression Language: true**
|
Review Comment:
The **Bucket** property line was removed from line 643 but added back at
line 656. This appears to be an unintentional reordering that could confuse
users expecting properties to be in a consistent order across similar
processors.
##########
PROCESSORS.md:
##########
@@ -1038,7 +1043,6 @@ In the list below, the names of required properties
appear in bold. Any other pr
| Name | Default Value | Allowable Values
| Description
|
|----------------------------------|---------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
-------------------------------------------------------|
-| **Bucket** | |
| The S3 bucket<br/>**Supports Expression
Language: true**
|
| Access Key | |
| AWS account access key<br/>**Supports
Expression Language: true**
|
Review Comment:
Similar to the previous comment, the **Bucket** property was removed from
line 1045 but added back at line 1059. This inconsistent property ordering
should be maintained across all AWS processor documentation.
##########
PROCESSORS.md:
##########
@@ -2601,7 +2612,6 @@ In the list below, the names of required properties
appear in bold. Any other pr
| Name | Default Value |
Allowable Values
| Description
|
|----------------------------------------|--------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
------------------------------------------------------------------------|
-| **Bucket** | |
| The S3 bucket<br/>**Supports
Expression Language: true**
|
| Access Key | |
| AWS account access
key<br/>**Supports Expression Language: true**
|
Review Comment:
The **Bucket** property reordering pattern appears again - removed from line
2614 but added back at line 2628. All AWS processor documentation should
maintain consistent property ordering.
##########
PROCESSORS.md:
##########
@@ -1698,7 +1706,6 @@ In the list below, the names of required properties
appear in bold. Any other pr
| Name | Default Value | Allowable Values
| Description
|
|----------------------------------|---------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
-------------------------------------------------------|
-| **Bucket** | |
| The S3 bucket<br/>**Supports Expression
Language: true**
|
| Access Key | |
| AWS account access key<br/>**Supports
Expression Language: true**
|
Review Comment:
The **Bucket** property ordering issue continues here - removed from line
1708 but added back at line 1722. This pattern should be consistent across all
AWS processor documentation sections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
