martinzink commented on code in PR #2044: URL: https://github.com/apache/nifi-minifi-cpp/pull/2044#discussion_r2514249977
########## behave_framework/src/minifi_test_framework/core/helpers.py: ########## @@ -0,0 +1,73 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +from __future__ import annotations + +import logging +import time +from collections.abc import Callable + +import docker +from minifi_test_framework.core.minifi_test_context import MinifiTestContext + + +def log_due_to_failure(context: MinifiTestContext | None): + if context is not None: + for container in context.containers: + container.log_app_output() + context.minifi_container.log_app_output() + + +def wait_for_condition(condition: Callable[[], bool], timeout_seconds: float, bail_condition: Callable[[], bool], + context: MinifiTestContext | None) -> bool: + if bail_condition(): + logging.warning("Bail condition evaluated to 'True', aborting wait.") + log_due_to_failure(context) + return False + start_time = time.monotonic() + try: + while time.monotonic() - start_time < timeout_seconds: + if condition(): + return True + if bail_condition(): + logging.warning("Bail condition evaluated to 'True', aborting wait.") + log_due_to_failure(context) + return False + remaining_time = timeout_seconds - (time.monotonic() - start_time) + target_sleep = 1.0 if timeout_seconds < 30 else 10.0 + sleep_time = min(target_sleep, remaining_time) + if sleep_time > 0: + time.sleep(sleep_time) + except (Exception,): + logging.warning("Exception while waiting for condition") + log_due_to_failure(context) + return False + logging.warning("Timed out after %d seconds while waiting for condition", timeout_seconds) + log_due_to_failure(context) + return False + + +def run_cmd_in_docker_image(image_name: str, cmd: str, network: str) -> str: + client = docker.from_env() + output = client.containers.run(image=image_name, + command=["/bin/sh", "-c", cmd], + remove=True, + stdout=True, + stderr=True, + network=network, + detach=False) + return output.decode("utf-8") Review Comment: yeah, we discussed it yesterday this one will throw when encountering non-zero exit code thus failing the test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
