szaszm commented on code in PR #2044: URL: https://github.com/apache/nifi-minifi-cpp/pull/2044#discussion_r2499384152
########## .github/workflows/create-release-artifacts.yml: ########## @@ -0,0 +1,42 @@ +name: "Create Release Artifacts" + +on: [workflow_dispatch] +env: + CMAKE_FLAGS: -DCMAKE_BUILD_TYPE=Release -DCI_BUILD=ON -DENABLE_ALL=ON -DMINIFI_FAIL_ON_WARNINGS=OFF -DDOCKER_BUILD_ONLY=ON Review Comment: release artifacts shouldn't be CI_BUILD=ON ########## docker/RunBehaveTests.sh: ########## @@ -0,0 +1,200 @@ +#!/bin/bash + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the \"License\"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an \"AS IS\" BASIS, Review Comment: quotes in the license headers shouldn't be escaped, they're just comments ########## extensions/azure/tests/features/environment.py: ########## Review Comment: A comment describing the purpose of mechanics like this would be nice. ########## extensions/aws/tests/features/steps/s3_server_container.py: ########## Review Comment: multiple files are missing license header -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
