lkuchars commented on code in PR #10105:
URL: https://github.com/apache/nifi/pull/10105#discussion_r2254123723
##########
nifi-extension-bundles/nifi-confluent-platform-bundle/nifi-confluent-schema-registry-service/src/main/java/org/apache/nifi/confluent/schemaregistry/client/CachingSchemaRegistryClient.java:
##########
@@ -47,21 +52,30 @@ public CachingSchemaRegistryClient(final
SchemaRegistryClient toWrap, final int
.maximumSize(cacheSize)
.expireAfterWrite(Duration.ofNanos(expirationNanos))
.build(client::getSchema);
+ definitionCache = Caffeine.newBuilder()
+ .maximumSize(cacheSize)
+ .expireAfterWrite(Duration.ofNanos(expirationNanos))
+ .build(client::getSchemaDefinition);
}
@Override
- public RecordSchema getSchema(final String schemaName) {
+ public RecordSchema getSchema(final String schemaName) throws IOException,
SchemaNotFoundException {
Review Comment:
Lets leave it, I think it's been generated based on the interface contract.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
