exceptionfactory commented on code in PR #10133:
URL: https://github.com/apache/nifi/pull/10133#discussion_r2232006645
##########
nifi-extension-bundles/nifi-splunk-bundle/nifi-splunk-processors/src/main/java/org/apache/nifi/processors/splunk/GetSplunk.java:
##########
@@ -131,6 +131,20 @@ public class GetSplunk extends AbstractProcessor
implements ClassloaderIsolation
.required(true)
.build();
+ public static final AllowableValue API_VERSION_V2 = new
AllowableValue("V2", "API Version 2 (Recommended)",
+ "Enables the Splunk Search API Version 2, which offers improved
performance and features.");
+ public static final AllowableValue API_VERSION_V1 = new
AllowableValue("V1", "API Version 1 (Legacy)",
Review Comment:
I recommend removing the `Recommend` and `Legacy` labels from the display
name, and keep the references in the description.
```suggestion
public static final AllowableValue API_VERSION_V2 = new
AllowableValue("V2", "API Version 2",
"Enables the Splunk Search API Version 2, which offers improved
performance and features.");
public static final AllowableValue API_VERSION_V1 = new
AllowableValue("V1", "API Version 1",
```
##########
nifi-extension-bundles/nifi-splunk-bundle/nifi-splunk-processors/src/main/java/org/apache/nifi/processors/splunk/GetSplunk.java:
##########
@@ -131,6 +131,20 @@ public class GetSplunk extends AbstractProcessor
implements ClassloaderIsolation
.required(true)
.build();
+ public static final AllowableValue API_VERSION_V2 = new
AllowableValue("V2", "API Version 2 (Recommended)",
+ "Enables the Splunk Search API Version 2, which offers improved
performance and features.");
+ public static final AllowableValue API_VERSION_V1 = new
AllowableValue("V1", "API Version 1 (Legacy)",
+ "Uses the Splunk Search API Version 1 (legacy).");
+
+ public static final PropertyDescriptor API_VERSION_CHOICE = new
PropertyDescriptor.Builder()
+ .name("Splunk Search API Version")
Review Comment:
Recommend adjusting the variable and property name, the context of Splunk
Search is already implied based on the Processor.
```suggestion
public static final PropertyDescriptor API_VERSION = new
PropertyDescriptor.Builder()
.name("API Version")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
