dan-s1 commented on code in PR #10133:
URL: https://github.com/apache/nifi/pull/10133#discussion_r2229673947
##########
nifi-extension-bundles/nifi-splunk-bundle/nifi-splunk-processors/src/main/java/org/apache/nifi/processors/splunk/GetSplunk.java:
##########
@@ -575,6 +589,17 @@ protected Service createSplunkService(final ProcessContext
context) {
Service.setSSLSocketFactory(sslContextProvider.createContext().getSocketFactory());
}
+ final String chosenApiVersion =
context.getProperty(API_VERSION_CHOICE).getValue();
+ boolean enableV2SearchApi;
+
+ if (API_VERSION_V2.getValue().equals(chosenApiVersion)) {
+ enableV2SearchApi = true;
+ } else {
+ enableV2SearchApi = false;
+ }
+
+ serviceArgs.add("enableV2SearchApi", enableV2SearchApi);
Review Comment:
I am no Splunk expert but I cannot seem to find the `enableV2SearchApi`
setting when Googling Splunk Java SDK and this setting name. Where is it
located? It would be a good idea to annotate the ticket with a link to this
setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
