szaszm commented on code in PR #1930:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1930#discussion_r2219619088
##########
libminifi/include/core/FlowConfiguration.h:
##########
@@ -84,8 +84,7 @@ class FlowConfiguration : public CoreComponentImpl {
~FlowConfiguration() override;
// Create Processor (Node/Input/Output Port) based on the name
- std::unique_ptr<core::Processor> createProcessor(const std::string &name,
const utils::Identifier &uuid);
- std::unique_ptr<core::Processor> createProcessor(const std::string &name,
const std::string &fullname, const utils::Identifier &uuid);
+ std::unique_ptr<core::Processor> createProcessor(const std::string
&class_short, const std::string &fullclass, const std::string &name, const
utils::Identifier &uuid);
Review Comment:
maybe we should rename name to object_name to differentiate it from the
other two names
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
