adamdebreceni commented on code in PR #1930:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1930#discussion_r2218984750
##########
minifi-api/include/minifi-cpp/core/ClassLoader.h:
##########
@@ -62,15 +65,19 @@ class ClassLoader {
*/
virtual void registerClass(const std::string &clazz,
std::unique_ptr<ObjectFactory> factory) = 0;
+ virtual void registerClass(const std::string &clazz,
std::unique_ptr<ProcessorFactory> factory) = 0;
+
virtual void unregisterClass(const std::string& clazz) = 0;
- virtual std::optional<std::string> getGroupForClass(const std::string
&class_name) const = 0;
+ [[nodiscard]] virtual std::optional<std::string> getGroupForClass(const
std::string &class_name) const = 0;
+
+ [[nodiscard]] virtual std::unique_ptr<CoreComponent> instantiate(const
std::string &class_name, const std::string &name,
std::function<bool(CoreComponent*)> filter) = 0;
- virtual std::unique_ptr<CoreComponent> instantiate(const std::string
&class_name, const std::string &name, std::function<bool(CoreComponent*)>
filter) = 0;
+ [[nodiscard]] virtual std::unique_ptr<CoreComponent> instantiate(const
std::string &class_name, const utils::Identifier &uuid,
std::function<bool(CoreComponent*)> filter) = 0;
- virtual std::unique_ptr<CoreComponent> instantiate(const std::string
&class_name, const utils::Identifier &uuid, std::function<bool(CoreComponent*)>
filter) = 0;
+ [[nodiscard]] virtual std::unique_ptr<CoreComponent> instantiate(const
std::string &class_name, const std::string &name, const utils::Identifier
&uuid, std::function<bool(CoreComponent*)> filter) = 0;
Review Comment:
agreed, but we would need to touch the ObjectFactory interface as well, I
would rather change this separately, (also remove the instantiateRaw)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
