lordgamez commented on PR #1930:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1930#issuecomment-3048333179
There seems to be an issue when building the ConsumeWindowsEventLog tests
that should be fixed:
```
2025-07-07T11:08:08.7010562Z
D:\a\nifi-minifi-cpp\nifi-minifi-cpp\extensions\windows-event-log\tests\ConsumeWindowsEventLogTests.cpp(96,3):
error C2440: '<function-style-cast>': cannot convert from 'const char [4]' to
'ConsumeWindowsEventLog'
2025-07-07T11:08:08.7069228Z
REQUIRE_NOTHROW(ConsumeWindowsEventLog("one"));
2025-07-07T11:08:08.7179152Z ^
2025-07-07T11:08:08.7277068Z
D:\a\nifi-minifi-cpp\nifi-minifi-cpp\extensions\windows-event-log\tests\ConsumeWindowsEventLogTests.cpp(96,3):
note:
'org::apache::nifi::minifi::processors::ConsumeWindowsEventLog::ConsumeWindowsEventLog':
no overloaded function could convert all the argument types
2025-07-07T11:08:08.7364078Z
D:\a\nifi-minifi-cpp\nifi-minifi-cpp\extensions\windows-event-log\ConsumeWindowsEventLog.h(265,1):
note: could be
'org::apache::nifi::minifi::processors::ConsumeWindowsEventLog::ConsumeWindowsEventLog(const
org::apache::nifi::minifi::processors::ConsumeWindowsEventLog &)'
2025-07-07T11:08:08.7406366Z };
2025-07-07T11:08:08.7522250Z ^
2025-07-07T11:08:08.7643170Z
D:\a\nifi-minifi-cpp\nifi-minifi-cpp\extensions\windows-event-log\tests\ConsumeWindowsEventLogTests.cpp(96,3):
note:
'org::apache::nifi::minifi::processors::ConsumeWindowsEventLog::ConsumeWindowsEventLog(const
org::apache::nifi::minifi::processors::ConsumeWindowsEventLog &)': cannot
convert argument 1 from 'const char [4]' to 'const
org::apache::nifi::minifi::processors::ConsumeWindowsEventLog &'
2025-07-07T11:08:08.7701217Z
REQUIRE_NOTHROW(ConsumeWindowsEventLog("one"));
2025-07-07T11:08:08.7769831Z ^
2025-07-07T11:08:08.7881948Z
D:\a\nifi-minifi-cpp\nifi-minifi-cpp\extensions\windows-event-log\tests\ConsumeWindowsEventLogTests.cpp(96,3):
note: Reason: cannot convert from 'const char [4]' to 'const
org::apache::nifi::minifi::processors::ConsumeWindowsEventLog'
2025-07-07T11:08:08.8001764Z
D:\a\nifi-minifi-cpp\nifi-minifi-cpp\extensions\windows-event-log\ConsumeWindowsEventLog.h(83,3):
note: or
'org::apache::nifi::minifi::processors::ConsumeWindowsEventLog::ConsumeWindowsEventLog(org::apache::nifi::minifi::core::ProcessorMetadata)'
2025-07-07T11:08:08.8064021Z explicit
ConsumeWindowsEventLog(core::ProcessorMetadata metadata);
2025-07-07T11:08:08.8109139Z ^
2025-07-07T11:08:08.8230223Z
D:\a\nifi-minifi-cpp\nifi-minifi-cpp\extensions\windows-event-log\tests\ConsumeWindowsEventLogTests.cpp(96,3):
note:
'org::apache::nifi::minifi::processors::ConsumeWindowsEventLog::ConsumeWindowsEventLog(org::apache::nifi::minifi::core::ProcessorMetadata)':
cannot convert argument 1 from 'const char [4]' to
'org::apache::nifi::minifi::core::ProcessorMetadata'
2025-07-07T11:08:08.8337608Z
REQUIRE_NOTHROW(ConsumeWindowsEventLog("one"));
2025-07-07T11:08:08.8411048Z ^
2025-07-07T11:08:08.8447393Z
D:\a\nifi-minifi-cpp\nifi-minifi-cpp\extensions\windows-event-log\tests\ConsumeWindowsEventLogTests.cpp(96,3):
note: 'org::apache::nifi::minifi::core::ProcessorMetadata::ProcessorMetadata':
no overloaded function could convert all the argument types
2025-07-07T11:08:08.8554164Z
D:\a\nifi-minifi-cpp\nifi-minifi-cpp\minifi-api\include\minifi-cpp/core/ProcessorMetadata.h(30,1):
note: could be
'org::apache::nifi::minifi::core::ProcessorMetadata::ProcessorMetadata(org::apache::nifi::minifi::core::ProcessorMetadata
&&)'
2025-07-07T11:08:08.8704314Z };
2025-07-07T11:08:08.8735028Z ^
2025-07-07T11:08:08.8800638Z
D:\a\nifi-minifi-cpp\nifi-minifi-cpp\extensions\windows-event-log\tests\ConsumeWindowsEventLogTests.cpp(96,3):
note:
'org::apache::nifi::minifi::core::ProcessorMetadata::ProcessorMetadata(org::apache::nifi::minifi::core::ProcessorMetadata
&&)': cannot convert argument 1 from 'const char [4]' to
'org::apache::nifi::minifi::core::ProcessorMetadata &&'
2025-07-07T11:08:08.8920778Z
REQUIRE_NOTHROW(ConsumeWindowsEventLog("one"));
2025-07-07T11:08:08.9058312Z ^
2025-07-07T11:08:08.9064086Z
D:\a\nifi-minifi-cpp\nifi-minifi-cpp\extensions\windows-event-log\tests\ConsumeWindowsEventLogTests.cpp(96,3):
note: Reason: cannot convert from 'const char [4]' to
'org::apache::nifi::minifi::core::ProcessorMetadata'
2025-07-07T11:08:08.9150344Z
D:\a\nifi-minifi-cpp\nifi-minifi-cpp\extensions\windows-event-log\tests\ConsumeWindowsEventLogTests.cpp(96,3):
note: Conversion requires a second user-defined-conversion operator or
constructor
2025-07-07T11:08:08.9264233Z
D:\a\nifi-minifi-cpp\nifi-minifi-cpp\minifi-api\include\minifi-cpp/core/ProcessorMetadata.h(30,1):
note: or
'org::apache::nifi::minifi::core::ProcessorMetadata::ProcessorMetadata(const
org::apache::nifi::minifi::core::ProcessorMetadata &)'
2025-07-07T11:08:08.9412755Z };
2025-07-07T11:08:08.9424702Z ^
2025-07-07T11:08:08.9504626Z
D:\a\nifi-minifi-cpp\nifi-minifi-cpp\extensions\windows-event-log\tests\ConsumeWindowsEventLogTests.cpp(96,3):
note:
'org::apache::nifi::minifi::core::ProcessorMetadata::ProcessorMetadata(const
org::apache::nifi::minifi::core::ProcessorMetadata &)': cannot convert argument
1 from 'const char [4]' to 'const
org::apache::nifi::minifi::core::ProcessorMetadata &'
2025-07-07T11:08:08.9587260Z
REQUIRE_NOTHROW(ConsumeWindowsEventLog("one"));
2025-07-07T11:08:08.9750153Z ^
2025-07-07T11:08:08.9797497Z
D:\a\nifi-minifi-cpp\nifi-minifi-cpp\extensions\windows-event-log\tests\ConsumeWindowsEventLogTests.cpp(96,3):
note: Reason: cannot convert from 'const char [4]' to 'const
org::apache::nifi::minifi::core::ProcessorMetadata'
2025-07-07T11:08:08.9853818Z
D:\a\nifi-minifi-cpp\nifi-minifi-cpp\extensions\windows-event-log\tests\ConsumeWindowsEventLogTests.cpp(96,3):
note: Conversion requires a second user-defined-conversion operator or
constructor
2025-07-07T11:08:08.9944372Z
D:\a\nifi-minifi-cpp\nifi-minifi-cpp\extensions\windows-event-log\tests\ConsumeWindowsEventLogTests.cpp(96,3):
note: while trying to match the argument list '(const char [4])'
2025-07-07T11:08:09.0096413Z
D:\a\nifi-minifi-cpp\nifi-minifi-cpp\extensions\windows-event-log\tests\ConsumeWindowsEventLogTests.cpp(96,3):
note: while trying to match the argument list '(const char [4])'
2025-07-07T11:08:09.0145883Z
D:\a\nifi-minifi-cpp\nifi-minifi-cpp\extensions\windows-event-log\tests\ConsumeWindowsEventLogTests.cpp(97,3):
error C2440: '<function-style-cast>': cannot convert from 'initializer list'
to 'ConsumeWindowsEventLog'
2025-07-07T11:08:09.0215553Z REQUIRE_NOTHROW(ConsumeWindowsEventLog("two",
IdGenerator::getIdGenerator()->generate()));
```
I think this single clang-tidy issue can also be fixed:
```
/home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/extensions/systemd/ConsumeJournald.cpp:37:27:
error: parameter 'metadata' is passed by value and only copied once; consider
moving it to avoid unnecessary copies
[performance-unnecessary-value-param,-warnings-as-errors]
: core::ProcessorImpl{metadata}, libwrapper_{std::move(libwrapper)} {}
^
std::move( )
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
