adamdebreceni commented on code in PR #1930:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1930#discussion_r2161748081


##########
extensions/expression-language/ProcessContextExpr.h:
##########
@@ -34,25 +34,12 @@ namespace org::apache::nifi::minifi::core {
  */
 class ProcessContextExpr final : public core::ProcessContextImpl {
  public:
-  ProcessContextExpr(Processor& processor, 
controller::ControllerServiceProvider* controller_service_provider,
-                     const std::shared_ptr<core::Repository> &repo, const 
std::shared_ptr<core::Repository> &flow_repo,
-                     const std::shared_ptr<core::ContentRepository> 
&content_repo = core::repository::createFileSystemRepository())
-      : core::ProcessContextImpl(processor, controller_service_provider, repo, 
flow_repo, content_repo),
-        logger_(logging::LoggerFactory<ProcessContextExpr>::getLogger()) {
-  }
-
-  ProcessContextExpr(Processor& processor, 
controller::ControllerServiceProvider* controller_service_provider,
-                     const std::shared_ptr<core::Repository> &repo, const 
std::shared_ptr<core::Repository> &flow_repo, const 
std::shared_ptr<minifi::Configure> &configuration,
-                     const std::shared_ptr<core::ContentRepository> 
&content_repo = core::repository::createFileSystemRepository())
-      : core::ProcessContextImpl(processor, controller_service_provider, repo, 
flow_repo, configuration, content_repo),
-        logger_(logging::LoggerFactory<ProcessContextExpr>::getLogger()) {
-  }
-
+  using ProcessContextImpl::ProcessContextImpl;
   ~ProcessContextExpr() override = default;
 
   nonstd::expected<std::string, std::error_code> getProperty(std::string_view 
name, const FlowFile*) const override;
   nonstd::expected<std::string, std::error_code> 
getDynamicProperty(std::string_view name, const FlowFile*) const override;
-
+//

Review Comment:
   removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to