lordgamez commented on PR #1918: URL: https://github.com/apache/nifi-minifi-cpp/pull/1918#issuecomment-2789815684
> taking back the approval because #1930 from @adamdebreceni includes a refactor that injects the logger into the processors, and in the process also ensuring that each processor only has one logger. I think we should wait a bit more for that pull request to be ready. That's true, that also solves this issue. My problem is that currently two PRs #1920 and #1941 depend on this change from which one has been open for review for 1 month and the other is for more that 2 months. Waiting for #1930 to finish would probably need a few additional weeks and as it is a quite large change it may still need several additional weeks to review. I'm not sure it's worth waiting that long and keep going back to, rebasing and fixing up these PRs for months if we have the option to have these reviewed and merged in a short time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
