lordgamez commented on code in PR #1918:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1918#discussion_r1950821107


##########
minifi-api/include/minifi-cpp/core/ProcessSession.h:
##########
@@ -97,6 +97,8 @@ class ProcessSession : public virtual ReferenceContainer {
 
   // import from the data source.
   virtual void import(const std::string& source, const 
std::shared_ptr<core::FlowFile> &flow, bool keepSource = true, uint64_t offset 
= 0) = 0;
+  virtual void import(const std::string& source, 
std::vector<std::shared_ptr<FlowFile>> &flows, uint64_t offset, char 
inputDelimiter) = 0;
+  virtual void import(const std::string& source, 
std::vector<std::shared_ptr<FlowFile>> &flows, bool keepSource, uint64_t 
offset, char inputDelimiter) = 0;

Review Comment:
   The PR needed to be rebased to the latest minifi-api branch, that's why it 
showed as a newly added, change.



##########
minifi-api/include/minifi-cpp/core/Processor.h:
##########
@@ -83,6 +83,8 @@ class Processor : public virtual Connectable, public virtual 
ConfigurableCompone
   virtual void validateAnnotations() const = 0;
   virtual annotation::Input getInputRequirement() const = 0;
   virtual gsl::not_null<std::shared_ptr<ProcessorMetrics>> getMetrics() const 
= 0;
+  virtual std::string getProcessGroupUUIDStr() const = 0;
+  virtual void setProcessGroupUUIDStr(const std::string &uuid) = 0;

Review Comment:
   The PR needed to be rebased to the latest minifi-api branch, that's why it 
showed as a newly added, change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to