lordgamez commented on code in PR #1925:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1925#discussion_r1987138470
##########
cmake/BundledOpenSSL.cmake:
##########
@@ -51,15 +57,12 @@ function(use_openssl SOURCE_DIR BINARY_DIR)
set(OPENSSL_EXTRA_FLAGS
no-tests # Disable tests
- no-apps # disable executables
no-capieng # disable CAPI engine (legacy)
- no-dso # disable dynamic libraries
no-docs # disable docs and manpages
no-legacy # disable legacy modules
- no-module # disable dynamically loadable engines
- no-pinshared # don't pin shared libraries in the process
memory
Review Comment:
From what I read in the description I think it's better to keep shared
libraries pinned, in our case the fips provider, as without this it could
happen in runtime that the library is unloaded when unused, I think it's safer
to have it loaded through the agent's lifetime. If FIPS is unused then it
should not have any affect as no other shared libraries are used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
