lordgamez commented on code in PR #1925:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1925#discussion_r1983343787


##########
cmake/BundledOpenSSL.cmake:
##########
@@ -51,15 +57,12 @@ function(use_openssl SOURCE_DIR BINARY_DIR)
 
     set(OPENSSL_EXTRA_FLAGS
             no-tests            # Disable tests
-            no-apps             # disable executables
             no-capieng          # disable CAPI engine (legacy)
-            no-dso              # disable dynamic libraries
             no-docs             # disable docs and manpages
             no-legacy           # disable legacy modules
-            no-module           # disable dynamically loadable engines
-            no-pinshared        # don't pin shared libraries in the process 
memory

Review Comment:
   But these options are meant for the OpenSSL library options for loading the 
FIPS module, not for the FIPS target.
   - We need the binary of the latest OpenSSL target, not the FIPS target
   - Without the options to be able to load shared libraries, loading of the 
FIPS module fails with the following error:
   ```
   Failed to load FIPS module
   INSTALL FAILED
   4077F3DFF87D0000:error:07880025:common libcrypto 
routines:provider_init:reason(37):crypto/provider_core.c:949:name=fips
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to