fgerlits commented on code in PR #1938:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1938#discussion_r1975236667
##########
CMakeLists.txt:
##########
@@ -544,7 +544,49 @@ else()
set(CPACK_SOURCE_GENERATOR "TGZ")
endif(WIN32)
set(CPACK_SOURCE_PACKAGE_FILE_NAME "${ASSEMBLY_BASE_NAME}-source")
-set(CPACK_SOURCE_IGNORE_FILES
"/docs/generated/;${CMAKE_SOURCE_DIR}/build/;~$;${CPACK_SOURCE_IGNORE_FILES};${CMAKE_SOURCE_DIR}/.git/;${CMAKE_SOURCE_DIR}/.idea/;${CMAKE_SOURCE_DIR}/cmake-build-debug/")
+set(CPACK_SOURCE_IGNORE_FILES
+ "/build/"
Review Comment:
Yes, good idea. I was worried about `win_build_vs.bat`, but the `/` at the
end excludes (i.e. includes) that.
I have also added `build_description.cpp` to the ignore list, as that is
also a generated file. e4ce729b09f1172902880adf226d4d6a697b2928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
