szaszm commented on code in PR #1938:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1938#discussion_r1975189912
##########
CMakeLists.txt:
##########
@@ -544,7 +544,49 @@ else()
set(CPACK_SOURCE_GENERATOR "TGZ")
endif(WIN32)
set(CPACK_SOURCE_PACKAGE_FILE_NAME "${ASSEMBLY_BASE_NAME}-source")
-set(CPACK_SOURCE_IGNORE_FILES
"/docs/generated/;${CMAKE_SOURCE_DIR}/build/;~$;${CPACK_SOURCE_IGNORE_FILES};${CMAKE_SOURCE_DIR}/.git/;${CMAKE_SOURCE_DIR}/.idea/;${CMAKE_SOURCE_DIR}/cmake-build-debug/")
+set(CPACK_SOURCE_IGNORE_FILES
+ "/build/"
Review Comment:
I think this could be a wildcard to match more like in the .gitignore, but
I'm not sure of the syntax here. I often have build directories named
`build-gcc-make`, `build-gcc-ninja`, `build-clang-ninja` in addition to the
CLion-generated and bootstrap-generated ones.
```suggestion
"/.*build.*/"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
