szaszm commented on code in PR #1900:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1900#discussion_r1859413053
##########
extensions/windows-event-log/wel/WindowsEventLog.h:
##########
@@ -59,22 +59,19 @@ enum METADATA {
UNKNOWN
};
+using METADATA_NAMES = std::vector<std::pair<Metadata, std::string>>;
-// this is a continuous enum, so we can rely on the array
-
-using METADATA_NAMES = std::vector<std::pair<METADATA, std::string>>;
+nonstd::expected<std::string, std::error_code> formatEvent(EVT_HANDLE
metadata, EVT_HANDLE event, EVT_FORMAT_MESSAGE_FLAGS flags) noexcept;
Review Comment:
`EVT_HANDLE` is `void*`, but I couldn't wrap it in `gsl::not_null`, because
it's incompatible with `void*`. (`operator*` cannot return a reference to
`void`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
