szaszm opened a new pull request, #1900:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1900
Changes:
- change `enum METADATA` to `enum class Metadata`
- rewrite `getEventData` and `getEventMessage`. They no longer try with a
stack buffer first. That looks like a premature optimization, since there are
allocations in the function either way, and a user reported issues with the
call that may be resolved by this. The rewrite aims to follow modern C++ best
practices, instead of the unsafe C-like code it used to be.
- remove a few unused includes
- make `getComputerName` thread-safe and simpler. The max computer name is
reduced to 256, based on the MSDN example. I think the overwhelming majority of
computer FQDNs will fit in that just fine. Also changed it to truncate when
it's longer, instead of bailing out and returning "N/A"
- other various drive-by refactors
----------
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI
results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
