szaszm commented on a change in pull request #1249:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1249#discussion_r800672928
##########
File path: controller/Controller.h
##########
@@ -111,12 +111,12 @@ int
getFullConnections(std::unique_ptr<org::apache::nifi::minifi::io::Socket> so
org::apache::nifi::minifi::io::BufferStream stream;
stream.write(&op, 1);
stream.write("getfull");
- if (org::apache::nifi::minifi::io::isError(socket->write(stream.getBuffer(),
stream.size()))) {
+ if
(org::apache::nifi::minifi::io::isError(socket->write(stream.getBuffer()))) {
return -1;
}
// read the response
uint8_t resp = 0;
- socket->read(&resp, 1);
+ socket->read(gsl::make_span(reinterpret_cast<std::byte*>(&resp), 1));
Review comment:
yes, done in
[30de0dc](https://github.com/apache/nifi-minifi-cpp/pull/1249/commits/30de0dc2abaed028ebf8ebb08be2bd9fd86edb52)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
