szaszm commented on a change in pull request #1249:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1249#discussion_r798126742
##########
File path: libminifi/include/c2/PayloadSerializer.h
##########
@@ -209,7 +209,7 @@ class PayloadSerializer {
}
return node;
}
- static C2Payload deserialize(std::vector<uint8_t> data) {
+ static C2Payload deserialize(std::vector<std::byte> data) {
Review comment:
I don't mind small extra changes like this, I only avoid the large scope
expansions. Will change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
