lordgamez commented on a change in pull request #1244:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1244#discussion_r786869766



##########
File path: docker/Dockerfile
##########
@@ -61,6 +61,7 @@ ARG DISABLE_LZMA=OFF
 ARG DISABLE_BZIP2=OFF
 ARG ENABLE_SCRIPTING=ON

Review comment:
       Should we have scripting enabled by default? I just realized this and 
because the DISABLE_PYTHON_SCRIPTING flag is off by default, it automatically 
installs python packages which adds 80MBs to the image. I'm not sure if 
scripting should be enabled. (If it's needed by the users of the published 
minimal image then it should be enabled in that config)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to