lordgamez commented on a change in pull request #1244:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1244#discussion_r786847285
##########
File path: docker/Dockerfile
##########
@@ -159,6 +163,7 @@ RUN addgroup -g ${GID} ${USER} && adduser -u ${UID} -D -G
${USER} -g "" ${USER}
if [ "$ENABLE_JNI" = "ON" ]; then apk add --no-cache openjdk8-jre-base; fi
&& \
if [ "$ENABLE_PCAP" = "ON" ]; then apk add --no-cache libpcap; fi && \
if [ "$ENABLE_USB_CAMERA" = "ON" ]; then apk add --no-cache libpng libusb;
fi && \
+ if [ "$ENABLE_LUA_SCRIPTING" = "ON" ]; then apk add --no-cache lua; fi && \
Review comment:
I think we should also add a check for ENABLE_SCRIPTING flag here. Also
just a thought but maybe we could also include the ENABLE_ALL check here as
well for all of these optional packages.
##########
File path: docker/Dockerfile
##########
@@ -159,6 +163,7 @@ RUN addgroup -g ${GID} ${USER} && adduser -u ${UID} -D -G
${USER} -g "" ${USER}
if [ "$ENABLE_JNI" = "ON" ]; then apk add --no-cache openjdk8-jre-base; fi
&& \
if [ "$ENABLE_PCAP" = "ON" ]; then apk add --no-cache libpcap; fi && \
if [ "$ENABLE_USB_CAMERA" = "ON" ]; then apk add --no-cache libpng libusb;
fi && \
+ if [ "$ENABLE_LUA_SCRIPTING" = "ON" ]; then apk add --no-cache lua; fi && \
if [ "$ENABLE_OPENCV" = "ON" ] || [ "$ENABLE_BUSTACHE" = "ON" ]; then apk
add --no-cache boost; fi && \
if { [ "$ENABLE_PYTHON" = "ON" ] || [ "$ENABLE_SCRIPTING" = "ON" ]; } && [
-z "$DISABLE_PYTHON_SCRIPTING" ]; then apk add --no-cache python3-dev; fi
Review comment:
Not strictly related to this PR, but python3-dev should not be needed
here, only the python3 package. Also ENABLE_PYTHON check can be removed here as
it turns out that it's unrelated to the python scripting extension. (It's an
unused nanofi based extension.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
