exceptionfactory commented on a change in pull request #5424:
URL: https://github.com/apache/nifi/pull/5424#discussion_r720335046



##########
File path: 
nifi-stateless/nifi-stateless-api/src/main/java/org/apache/nifi/stateless/config/PropertiesFileEngineConfigurationParser.java
##########
@@ -218,4 +223,24 @@ private String getRequired(final Properties properties, 
final String key) throws
         return propertyValue.trim();
     }
 
+    private String getSensitivePropsKey(final File propertiesFile, final 
Properties properties) {

Review comment:
       I considered that, but also wanted to avoid complicating the dependency 
tree.  The `nifi-stateless-api` has no dependencies other than `nifi-api`, and 
should definitely avoid depending on `nifi-properties` or 
`nifi-properties-loader`. A new module is one option, but it seems a bit much 
for a single class and method. What do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to