gresockj commented on a change in pull request #5424:
URL: https://github.com/apache/nifi/pull/5424#discussion_r720329803
##########
File path:
nifi-stateless/nifi-stateless-bundle/nifi-stateless-engine/src/main/java/org/apache/nifi/stateless/flow/StandardStatelessDataflowFactory.java
##########
@@ -167,7 +163,9 @@ private synchronized PropertyEncryptor getEncryptor() {
return created;
}
- created =
getPropertyEncryptor(engineConfiguration.getSensitivePropsKey());
+ created = new
PropertyEncryptorBuilder(engineConfiguration.getSensitivePropsKey())
Review comment:
What do you think about making the algorithm provided by the stateless
properties instead of hard coding it here? I suppose this could always be
added later if we wanted to be more consistent with NiFi, and perhaps the use
case is already so small for sensitive props key that hard-coding is acceptable
here. However, I wanted to pose the question here.
##########
File path:
nifi-stateless/nifi-stateless-api/src/main/java/org/apache/nifi/stateless/config/PropertiesFileEngineConfigurationParser.java
##########
@@ -218,4 +223,24 @@ private String getRequired(final Properties properties,
final String key) throws
return propertyValue.trim();
}
+ private String getSensitivePropsKey(final File propertiesFile, final
Properties properties) {
Review comment:
What do you think about pulling some of this logic into a common utility
to be used by both `NiFiPropertiesLoader` and this class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
