markap14 commented on a change in pull request #5004:
URL: https://github.com/apache/nifi/pull/5004#discussion_r622391558
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat/AbstractHeartbeatMonitor.java
##########
@@ -343,4 +374,25 @@ public void onLocalNodeIdentifierSet(final NodeIdentifier
localNodeId) {
public void onNodeStateChange(final NodeIdentifier nodeId, final
NodeConnectionState newState) {
}
}
+
+ private class RemoveHeartbeatsOnNodeRemoval implements
ClusterTopologyEventListener {
Review comment:
Wow. There is no difference. Somehow I completely missed that we already
had that registered. I was expecting to see one registered on
start/unregistered on stop and it wasn't there so i added that in to ensure
that we were handling the case. Completely missed the fact a listener had
already been registered. Great catch. Will remove that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
