markap14 commented on pull request #5004: URL: https://github.com/apache/nifi/pull/5004#issuecomment-825826144
Thanks @jfrazee. Yeah, I did consider a timeout on some of those wait's. But if it does timeout, i dont know that it's really going to be able to recover. So it could either wait a while and then give up and throw an Exception or something, which would leave the node in "some" state. Or it could just wait forever. The advantage of waiting forever is that it's really just polling an external state and waiting for the desired state. So while waiting forever, if something results in the background tasks completing (such as a problematic network being addressed, or someone manually addressing an issue) it would continue on. I kind of feel like it makes sense to leave this part as-is for now and see if we run into situations later where we want to adjust it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
