tpalfy commented on a change in pull request #4629:
URL: https://github.com/apache/nifi/pull/4629#discussion_r518692323



##########
File path: 
nifi-nar-bundles/nifi-extension-utils/nifi-hadoop-utils/src/main/java/org/apache/nifi/hadoop/SecurityUtil.java
##########
@@ -141,4 +143,37 @@ public static boolean isSecurityEnabled(final 
Configuration config) {
         Validate.notNull(config);
         return 
KERBEROS.equalsIgnoreCase(config.get(HADOOP_SECURITY_AUTHENTICATION));
     }
+
+    public static <T> T callWithUgi(UserGroupInformation ugi, 
PrivilegedExceptionAction<T> action) throws IOException {

Review comment:
       It handles the `InterruptedException`. Most of the callers only declare 
`IOException`. This is a general pattern which could use a utility method in my 
opinion. Just in this case the wrapping would need to be replicated in 15 
places or so.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to