bbende commented on a change in pull request #4629:
URL: https://github.com/apache/nifi/pull/4629#discussion_r514338031



##########
File path: 
nifi-nar-bundles/nifi-extension-utils/nifi-hadoop-utils/src/main/java/org/apache/nifi/hadoop/SecurityUtil.java
##########
@@ -141,4 +143,37 @@ public static boolean isSecurityEnabled(final 
Configuration config) {
         Validate.notNull(config);
         return 
KERBEROS.equalsIgnoreCase(config.get(HADOOP_SECURITY_AUTHENTICATION));
     }
+
+    public static <T> T 
callWithUgi(CallableThrowingException<UserGroupInformation, IOException> 
ugiProvider, CallableThrowingException<T, IOException> function) throws 
IOException {

Review comment:
       I haven't looked too closely, but I was also wondering about the need 
for `CallableThrowingException `, isn't it basically providing the same thing 
as `PrivilegedExceptionAction` ?
   
   I would think the code inside the client services could just be:
    ```
   getUgi().doAs((PrivilegedExceptionAction<Object>)() -> {
      ...
   }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to