adamdebreceni commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r508247054
##########
File path: libminifi/src/core/ProcessSession.cpp
##########
@@ -66,10 +66,12 @@ ProcessSession::~ProcessSession() {
}
void ProcessSession::add(const std::shared_ptr<core::FlowFile> &record) {
- if (_updatedFlowFiles.find(record->getUUIDStr()) != _updatedFlowFiles.end())
{
+ utils::Identifier uuid;
+ record->getUUID(uuid);
+ if (_updatedFlowFiles.find(uuid) != _updatedFlowFiles.end()) {
Review comment:
you are right, whatever we consider `Nil` to be (invalid or valid), the
`getUUID` implementation is the same, created a ticket for refactoring our
`Identifier` treatment e.g. don't pass `.getUUIDStr()` when a `.getUUID()`
would be perfectly fine, and to replace all `.getUUID(uuid)` with the new
implementation, I imagine there are quite a number of places that will be
touched by that PR
the created ticket is
[here](https://issues.apache.org/jira/browse/MINIFICPP-1395)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
