adamdebreceni commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507758324
##########
File path: libminifi/include/utils/Id.h
##########
@@ -65,10 +67,11 @@ class Identifier {
bool operator!=(const Identifier& other) const;
bool operator==(const Identifier& other) const;
+ bool operator<(const Identifier& other) const;
bool isNil() const;
- std::string to_string() const;
+ SmallString<36> to_string() const;
Review comment:
I generally like if the types convey their usage, so we can have
functions expecting `UUIDString` and we will make no mistake passing it a
`"banana"` (the intent of the `Identifier::to_string` is not to return a
`std::string` but to stringify its value, and that representation is quite
constrained compared to `std::string`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
