kwin commented on issue #790: URL: https://github.com/apache/maven-shade-plugin/issues/790#issuecomment-3999808630
I would recommend to clarify https://github.com/apache/maven-shade-plugin/blob/06902bde990d317bc71654e8eaa62b4a1ad47ad2/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java#L33 with regards to field names. Although everything is named pattern, sometimes it is a 1. String value (`shadedPattern`, `shadedPathPattern`) or a 2. Regular expression pattern (`pattern`, `pathPattern`) or a 3. Ant-based glob pattern (`include`, `exclude`) The second category should also not be stored as `String` but rather as compiled `Pattern` to speed up the actual replacements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
