kwin opened a new issue, #790:
URL: https://github.com/apache/maven-shade-plugin/issues/790

   ### Affected version
   
   3.6.1
   
   ### Bug description
   
   According to all examples in 
https://maven.apache.org/plugins/maven-shade-plugin/examples/class-relocation.html
 and also in 
https://maven.apache.org/plugins/maven-shade-plugin/shade-mojo.html#relocations 
both `pattern` and `shadedPattern` contain `.` in a literal way (i.e. not 
representing an arbitrary character like in a regular expression).
   
   However the value is used as is when passing as first argument to 
`String.replaceFirst(String, String)`. In this case the `.` is used as 
placeholder in a regular expression.
   
   This leads to the following incorrect results:
   
   ```
   String relocated = new SimpleRelocator("org.foo", null, null, 
null).replaceClass("orgxfoo.foo.Bar");
   // relocated is now "hidden.orgxfoo.foo.Bar" but should be "orgxfoo.foo.Bar" 
because the pattern should not match
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to