kwin commented on code in PR #623:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/623#discussion_r2874047500
##########
doxia-integration-tools/src/main/java/org/apache/maven/doxia/tools/SiteTool.java:
##########
@@ -43,7 +43,10 @@ public interface SiteTool {
*
* @see Locale#ROOT
*/
- Locale DEFAULT_LOCALE = Locale.ROOT;
+ Locale DEFAULT_LOCALE = new Locale(
Review Comment:
> Two reasons:
>
> * I have designed identically to Java's system properties for that
> * I didn't use the mentioned method because I didn't want to be
inconsistent how to accept the locale string, namely reverse `#toString()`.
I don't particularly like the choice of JVM:
https://www.oracle.com/technical-resources/articles/javase/locale.html#using.
Since Locale.forLanguage(...) was introduced only with 1.7 is probably the
reason why they split it up. Also the `user` infix is really weird, as this is
not at all bound to a specific user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
