kwin commented on code in PR #623:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/623#discussion_r2873708120
##########
doxia-integration-tools/src/main/java/org/apache/maven/doxia/tools/SiteTool.java:
##########
@@ -43,7 +43,10 @@ public interface SiteTool {
*
* @see Locale#ROOT
*/
- Locale DEFAULT_LOCALE = Locale.ROOT;
+ Locale DEFAULT_LOCALE = new Locale(
Review Comment:
Why do we need three different properties, let us use
https://docs.oracle.com/javase/8/docs/api/java/util/Locale.html#forLanguageTag-java.lang.String-
and get the language tag from a single property.
Also regarding the property name I find `user` in it confusing. I would
propose just `maven.doxia.sitetools.default.locale`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
