kevinnammour commented on code in PR #3261:
URL: https://github.com/apache/maven-surefire/pull/3261#discussion_r2840956939


##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java:
##########
@@ -134,7 +137,8 @@ public StatelessXmlReporter(
             boolean phrasedClassName,
             boolean phrasedMethodName,
             boolean enableOutErrElements,
-            boolean enablePropertiesElement) {
+            boolean enablePropertiesElement,

Review Comment:
   What is the recommended best practice in this case? I considered exposing a 
fluent setter to enable method chaining (or maybe builder pattern), but I 
wanted to avoid introducing opinionated design choices that might impact the 
class unnecessarily.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to